Skip to content

fix(plot): scale peak heights without moving baselines - #131

Merged
nmrtist merged 3 commits into
mainfrom
fix/peak-height-scaling
Oct 24, 2026
Merged

nmrtist merged 3 commits into
mainfrom
fix/peak-height-scaling

Conversation

@nmrtist

@nmrtist nmrtist commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Summary

Wheel scaling moved stacked NMR baselines instead of changing peak height, making DOSY attenuation harder to compare.

  • Apply one display multiplier to numeric 1D traces, preserving baselines, spacing and relative attenuation for positive and negative peaks.
  • Keep X-axis wheel zoom and 2D coordinate zoom.
  • Show the multiplier and add View → Reset Peak Height, with undo, redo and project persistence.
  • Keep cursors, peak markers, threshold lines and trace labels aligned while leaving scientific data unchanged.
  • Update the English and Simplified Chinese guides.

Validation

  • cargo pr-check: passed.
  • Regression tests cover signed peak scaling, fixed baselines, navigation, undo/redo, reset and both project save modes.
  • npm run build in docs/: passed.

UI display logic

  • Reset Peak Height uses the command catalog and is searchable in the command palette.
  • Unavailable reset actions remain visible with an actionable disabled reason.
  • No layout changes from background events; panels are never auto-closed.
  • User-visible behavior is documented in English and Simplified Chinese.

@nmrtist
nmrtist enabled auto-merge (squash) October 24, 2026 10:35
@nmrtist
nmrtist merged commit 6b3808c into main Oct 24, 2026
11 checks passed
@nmrtist
nmrtist deleted the fix/peak-height-scaling branch October 24, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant