Repository navigation
Fix handling of scalar vs length-1 vector in modelValues, including for as.matrix column names - #69
Merged
Merged
Conversation
…or as.matrix column names
…t up to date with nCompiler.
Contributor
Author
|
@paciorek This has passed tests. Ok if I merge it? (It had initial test failures that I think were due to using an older version of nCompiler, when it needed to be using a just-merged version of that. It passed subsequently on new runs.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on recent extension of nList in nCompiler to be able to query the nDim and scalar element type of nLists of basic types. This allows that from an nList base class we can query this information for the underlying derived nList object. That in turn allows
as.matrixand related steps for amodelValuesto correctly determine whether a column of output is a true scalar (e.g."mu") or a length-1 vector (e.g. "mu[1]"), matching nimble's behavior.@paciorek I'm hoping this is relatively simple and doesn't impact much else so if tests pass we can merge it.