Repository navigation
Conversation
bringing in code from `handle-keywords`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to make a couple changes to keyword handling to allow dmnorm compilation to work. In addition it brings in some changes to dmnorm-related test code in
test-nimbleModel.Rthat was in the defuncthandle-keywordsbranch.I think the keyword handling stuff is ok (though there is more to discuss there as seen in issue #60 ).
However, there is a C++ compilation error seemingly related to getParam.
@perrydv I'm not reproducing that here -- instead please run the test code block in lines 791-804 of
test-nimbleModel.R