Repository navigation
full pass of styler over R and tests/testthat directories - #64
Merged
Merged
Conversation
Contributor
|
Fine by me for us to merge this. Too bad about the big diffs for tests, but we don't use git blame as much for tests anyway, I don't think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@paciorek See what you think of this. Formatting changes are minor in R and major in
tests/testthat.There are a few things I wish were handled differently, but I don't want to get into customizing this right now and I'm willing to accept the tool's opinions in order to have some standardization.