Repository navigation
fix: restore file previews in trash and shares views - #317
Open
suet-kei-chan wants to merge 1 commit into
Open
suet-kei-chan wants to merge 1 commit into
suet-kei-chan wants to merge 1 commit into
Conversation
Nodes in the trashbin and shares views carry no usable etag: the trashbin DAV getetag is an all-digit timestamp that the XML parser turns into a number, so webdav-client nulls it, and the shares list comes from the OCS API which has no etag at all. Both then fell back to mtime.getTime(), a number, and the following .slice() threw inside the surrounding try/catch. The swallowed error left previewUrl undefined, so every file rendered the generic file icon instead of its thumbnail or mime icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes in the trashbin and shares views carry no usable etag: the trashbin DAV getetag is an all-digit timestamp that the XML parser turns into a number, so webdav-client nulls it, and the shares list comes from the OCS API which has no etag at all.
Both then fell back to mtime.getTime(), a number, and the following .slice() threw inside the surrounding try/catch. The swallowed error left previewUrl undefined, so every file rendered the generic file icon instead of its thumbnail or mime icon.
Summary
TODO
Checklist