Repository navigation
add appstore build publish workflow - #373
Conversation
2541012 to
47e9759
Compare
|
Where is this workflow coming from? It's not the exact same as https://github.com/nextcloud/.github/blob/master/workflow-templates/appstore-build-publish.yml |
47e9759 to
a5eca14
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
a5eca14 to
c182bae
Compare
It comes mostly from the template, but a few things were changed to make it work for community (like not needing to be in the nextcloud-releases org, supporting custom release environment to attempt to replace the need for a separate organization for community apps and to specify the app name as for a lot of community apps the app name doesn't match the repo name). I also added a diff as I realized that would also make it easier to update in the future and help you with seeing what I changed. |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Thanks for adding the diff, that is quite useful for the review and to keep maintaining it.
Did you test this workflow on a real app yet?
| - run: | | ||
| - # Split and keep last | ||
| - echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV | ||
| - echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV | ||
| + run: echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV |
There was a problem hiding this comment.
This is because a lot of community apps don't use the same name for their github repo as for the app id unlike for our own repos where that is followed pretty consistently. (Quick example from a very recent app certificate request https://code.bastelquartier.de/julius.koenig/nextcloud-mail-provisioning)
Not on a "real app", but I did test that everything except for the appstore publishing works for a sample app in a private repo. I didn't want to overwrite any of the apps I could publish for with a dummy release. Also the nice thing about that diff is that the workflow update script on nextcloud/.github automatically applies that diff when you run it. |
Adds release workflow to template for community apps. I'll need to update the documentation at the link to fit with this.
Documentation:
🤖 AI (if applicable)