Skip to content

feat(direct-editing): add missing check - #17575

Merged
alperozturk96 merged 2 commits into
masterfrom
feat/use-direct-api
Sep 22, 2026
Merged

feat(direct-editing): add missing check#17575
alperozturk96 merged 2 commits into
masterfrom
feat/use-direct-api

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

alperozturk96
alperozturk96 commented Sep 7, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt
creator?.editor,
creator?.id,
template.title
template.id

@alperozturk96 alperozturk96 Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/richdocuments/blob/main/lib/DirectEditing/AbstractOfficeCreator.php#L79

Have to be id.

alperozturk96
alperozturk96 commented Sep 7, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt
}

private fun creatorsActionsFromCollabora(): List<CreatorAction> {
// richdocuments 11+ serves its creators through DirectEditing, so the legacy entries would be duplicates.

@alperozturk96 alperozturk96 Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced via v11: https://github.com/nextcloud/richdocuments/blob/v11.0.0/lib/DirectEditing/CreateDocument.php

@alperozturk96 alperozturk96 linked an issue Sep 7, 2026 that may be closed by this pull request
Implement direct editing API nextcloud/files-clients#31
Closed
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17575-IT-master-12-00

@github-actions

github-actions Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 6801e78
Version 17575
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 17, 2026
@alperozturk96

alperozturk96 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@alperozturk96
feat(direct-editing): add missing check
230b13d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...android/ui/fragment/OCFileListBottomSheetDialog.kt 0.00% 2 Missing ⚠️
...p/src/main/java/com/nextcloud/utils/EditorUtils.kt 0.00% 1 Missing ⚠️
.../android/ui/dialog/ChooseTemplateDialogFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

daniele-verducci
daniele-verducci approved these changes Sep 22, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the various instances, never seen duplicates, works.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1818
Total360360

@alperozturk96
alperozturk96 merged commit 5e4c59a into master Sep 22, 2026
24 of 25 checks passed
@alperozturk96
alperozturk96 deleted the feat/use-direct-api branch September 22, 2026 13:06
@backportbot backportbot Bot mentioned this pull request Sep 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.1

Development

Successfully merging this pull request may close these issues.

Implement direct editing API

2 participants

@alperozturk96 @daniele-verducci