Repository navigation
WebSocket Ack Request over IPC and FFI - #207
Conversation
… means The comment said this was only used when broadcasting to other nodes in a cluster, which the work that made a send mean the same thing wherever the connection is had already made untrue. A message to a client on this node is waited for the same way, which was the point of it. It now says that, and says what a caller can otherwise get wrong, that a message which does not ask its client to acknowledge it is settled by the write, since nothing was asked and no answer is coming. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…er ipc A handler running as a separate process could not ask for one. The contract carried the clients to inform if a message was lost and the caller to name in that event, and nothing for the acknowledgement those exist alongside, so the runtime built the context with the request hard coded off. Everything the two branches before this built, waiting for the client, sending again while attempts remain and declaring a message lost, was reachable only by a caller holding the bindings directly. The message carries the request now, and the runtime builds a context where a handler asked for either that or clients informed, rather than only the latter. The acknowledgement a handler receives for the send then reports what its client made of the message rather than what the socket made of it. What a handler can get wrong is recorded on the field. The message has to ask its client for an acknowledgement in the payload it composes, which the runtime does not write, so asking for one on a message that asks nothing waits until the runtime gives up on it. The stand-in registry in the tests keeps what each send asked for, so the test covers the path from the frame to the registry rather than the decision alone, which is where this was wrong. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…dings Both bindings described the shape a handler returns and not what returning it causes. For a source that acknowledges, the result decides whether the message is delivered again, which is the one thing a handler author needs to know before answering, and neither binding said it. They now record that a success acknowledges the message and a failure leaves it on its source, that reporting success for work a handler did not do means never seeing that work again, that naming failures answers for each message in a batch separately while naming none answers for the whole of it, and that a non-empty list is taken as the answer even alongside a success. The id a failure names has to be the one the message arrived with. One matching nothing in the batch would leave nothing behind, so the runtime refuses the whole answer rather than acknowledging a batch it cannot apply. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe runtime now forwards WebSocket client acknowledgement requests through ChangesWebSocket acknowledgement propagation
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Buf (1.72.0)libs/runtime/proto/celerity/runtime/v1/runtime.protofatal: unable to access 'https://github.com/newstack-cloud/celerity.git/': Failed to connect to github.com port 443 via 127.0.0.1 after 0 ms: Could not connect to server Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Description
Adds support for WebSocket Ack requests over IPC and FFI for the runtime.
Summary by CodeRabbit
New Features
Documentation