Repository navigation
feat(valkey): support version and persistence in apply - #799
Merged
Merged
Conversation
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v6.5.0 - 2026-10-12Full Changelog: v6.4.0...v6.5.0 🚀 Features
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unconditional debug dump pollutes CLI output during every Valkey apply.
1 open finding
What changed in this PR
Adds Valkey version and persistence support to native apply manifests while preserving omitted optional fields.
Changes:
- Converts manifest versions into GraphQL enum values.
- Forwards persistence and conditionally omits optional mutation fields.
- Adds validation, mutation, conversion tests, and documentation.
| File | Description |
|---|---|
internal/valkey/valkey.go |
Forwards version, persistence, and optional policy fields. |
internal/valkey/valkey_test.go |
Tests mutation payload serialization. |
internal/naisapi/gql/generated.go |
Makes optional input fields omittable. |
internal/apply/validate_test.go |
Tests version and persistence validation. |
internal/apply/resource/valkey.go |
Converts manifest fields into API values. |
internal/apply/resource/valkey_test.go |
Tests manifest-to-API conversion. |
internal/apply/resource/parse_test.go |
Updates persistence parsing expectations. |
internal/apply/README.md |
Documents the supported manifest fields. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Convert manifest versions to GraphQL enums and forward persistence settings. Omit empty maxMemoryPolicy values from create and update requests.
thokra-nav
force-pushed
the
vk_version_persistence
branch
from
October 12, 2026 13:22
9d2d7e8 to
e204fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert manifest versions to GraphQL enums and forward persistence settings. Omit empty maxMemoryPolicy values from create and update requests.