Skip to content

Add viewport meta tag to fractal preview pages (Fix #1158) - #1159

Open
stephaniehobson wants to merge 1 commit into
mainfrom
1158-viewport-meta
Open

stephaniehobson wants to merge 1 commit into
mainfrom
1158-viewport-meta

Conversation

@stephaniehobson

Copy link
Copy Markdown
Contributor

Description

Add viewport meta tag to fractal preview pages

Issue

Fix #1158

Testing

This page depends on media queries to trigger for the demo to work. At smaller sizes the text under the headings should collapse.

@stephaniehobson stephaniehobson added the Needs:Review 👋 Ready for Developer Review label Sep 21, 2026
Comment thread components/_preview-card-dark.html Outdated
<html dir="ltr" class="no-js">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">

@knowler knowler Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to drop the initial-scale=1 bit in these, but it doesn’t hurt to keep it (especially if it’s consistent elsewhere). It was necessary for older versions of iOS and Android, but has since been fixed. I only became aware of this within the last month or so.

Suggested change
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="viewport" content="width=device-width">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! End of an era.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs:Review 👋 Ready for Developer Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add viewport meta tag to fractal full page demos.

2 participants