Remove legacy browser-support CSS - #1137
Merged
Merged
Conversation
stephaniehobson
force-pushed
the
v23/support-css
branch
from
September 10, 2026 20:12
d72d5f9 to
17762f4
Compare
stephaniehobson
added this pull request to stack #1146
September 11, 2026 17:21
stephaniehobson
force-pushed
the
v23/support-css
branch
from
September 15, 2026 16:46
17762f4 to
8e9141e
Compare
stephaniehobson
marked this pull request as ready for review
September 17, 2026 19:13
stephaniehobson
force-pushed
the
v23/support-css
branch
from
September 17, 2026 19:13
8e9141e to
2976625
Compare
knowler
reviewed
Sep 19, 2026
knowler
left a comment
knowler
left a comment
Collaborator
There was a problem hiding this comment.
There are some details polyfill related styles that are left in https://github.com/mozilla/protocol/blob/2976625806a7ea026ff49a61d0b257dafba25d03/assets/sass/protocol/base/elements/_details.scss
stephaniehobson
force-pushed
the
v23/support-css
branch
from
September 21, 2026 19:17
2976625 to
6d1fd97
Compare
Everything here is unconditionally true for Firefox ESR, Safari 15.6+, and evergreen browsers, so the feature-query gates and legacy prefixes around it are dead weight. - Unwrapped @supports - Removed the _reset.scss which made HTML5 elements display:block (except summary which would revert to display: list-item) - Removed the &::-ms-expand selector in the Select form reset. - Replaced -webkit-appearance with the standard unprefixed appearance - Re-enabled property-no-vendor-prefix and value-no-vendor-prefix in .stylelintrc.json - appearance: button changed to appearance: auto - Removed "in IE"/"in Edge and IE" references and replaced them with comments explaining we're stuck with them.
stephaniehobson
force-pushed
the
v23/support-css
branch
from
September 21, 2026 19:18
6d1fd97 to
6831ce9
Compare
Contributor
Author
|
@knowler We should leave those. It's possible to invoke MzpDetails without using the details/summary elements and we want the styles between the two to match. There's a demo but it seems to be broken 🤦♀️. I made #1158 |
knowler
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes some vendor prefixes. Unwraps some @supports declarations. Updates comments that are IE specific to explain they're legacy parts of the reset.
I have documented this change in the design system.I have recorded this change in(covered by existing messages)CHANGELOG.md.Issue
#1135
Testing