Add GitHub Actions CI workflow for lint and tests (#79) by stephaniehobson · Pull Request #447 · mozilla/ensemble

stephaniehobson · 2026-09-18T23:32:24Z

One-line summary

Run lint, the Vitest unit tests, and the Playwright end-to-end tests on every push to main and every pull request.

Significant changes and points to review

Bring AGENTS.md up to date with the Vite, Vitest, and Playwright toolchain, and say that CI now exists. CONTRIBUTING.md gets the same CI fix.
Stop checking external links in the Playwright suite. loadsSuccessfully in tests/playwright/utils.js now skips any URL outside the app's origin, so internal links are still checked.

Issue / Bugzilla link

#79

Testing

Check that "CI / Lint and test" and "CI / End-to-end tests" both appear in this PR's Checks tab and pass.

stephaniehobson · 2026-10-02T02:48:47Z

@@ -0,0 +1,937 @@
+# Add a GitHub Actions workflow that lints and tests every commit and pull request


@stevejalim This seems like A LOT for the amount of work that was actually done. Is this the kind of exec plan you expect to see or do I need to get it to be less verbose. (Do I really need to know it rebased?)

No, I don't think we need to knoiw it rebased and it's worth adding something like "don't log routine development operations in the execplan. Record consequential decisions and surprises" into https://github.com/mozilla/ensemble/blob/main/docs/execplans/README.md or - perhaps better - https://github.com/mozilla/ensemble/blob/main/.claude/skills/execplans/references/PLANS.md

Runs lint, the Vitest unit tests, and the Playwright end-to-end tests on every push to main and every pull request. Stops checking external links in the Playwright suite, because third-party bot walls fail them on GitHub's runners.

stevejalim · 2026-10-13T15:05:45Z

-test('All links work', async ({ page }) => {
-    await expect(page.locator('#contact')).toBeVisible();
-    await linksWork(page, '#contact a');
-});


I trust you, but am curious why we are dropping this test

Ah it's becuase loadsSuccessfully has changed

Copilot

🟡 Changes recommended

The workflow fork guards, Playwright coverage, and documented validation sequence need correction before approval.

5 open findings

3 resolved since last review

🧠 Review effort: Lite

+Issue #79 (<https://github.com/mozilla/ensemble/issues/79>) was opened in 2018, when a pull request
+got no CI feedback. It asks for CI that lints and runs the tests on every commit. The repository
+once had CircleCI, but it was turned off in February 2018 (`433a465`), and nothing replaced it.
+There is no `.github/` directory today.


+and `#not-found` does not. For an external link, it opens the URL in a new browser page and expects
+HTTP 200, with three attempts and backoff, plus a redirect-only special case for
+`donate.mozilla.org`. `footer.spec.js` and the "All links work" test in `contact.spec.js` check only


stevejalim

LGTM - i've DMed two robot insights if you want

stevejalim · 2026-10-13T15:08:50Z

Can we rename this to not have the -shorter part, to bring it in line with what PLAN.md asks for

#79)

* Revise execplan instructions * Add GitHub Actions CI workflow for lint and tests (#79) Runs lint, the Vitest unit tests, and the Playwright end-to-end tests on every push to main and every pull request. Stops checking external links in the Playwright suite, because third-party bot walls fail them on GitHub's runners. * Remove a link test that can no longer fail, and a stale PLANS.md claim (#79) * Compile CSS and bound job time in CI, and tidy link tests (#79)

stephaniehobson added this pull request to stack #445 September 18, 2026 23:32

stephaniehobson changed the title ~~Add CI based on GitHub Actions~~ Add GitHub Actions CI workflow for lint and tests (#79) Sep 18, 2026

stephaniehobson marked this pull request as draft September 18, 2026 23:39

stephaniehobson force-pushed the 79--github-actions-ci branch 4 times, most recently from 5831bff to f846c70 Compare September 21, 2026 17:40

stephaniehobson requested a lite review from Copilot September 21, 2026 17:40

Copilot started reviewing on behalf of stephaniehobson September 21, 2026 17:41

View session

This comment was marked as outdated.

Sign in to view

stephaniehobson force-pushed the 79--github-actions-ci branch 3 times, most recently from 9a3ca39 to 47c0806 Compare September 21, 2026 18:51

stephaniehobson requested a lite review from Copilot September 21, 2026 18:51

Copilot started reviewing on behalf of stephaniehobson September 21, 2026 18:52

View session

This comment was marked as outdated.

Sign in to view

stephaniehobson requested a lite review from Copilot September 21, 2026 19:12

Copilot started reviewing on behalf of stephaniehobson September 21, 2026 19:13

View session

This comment was marked as outdated.

Sign in to view

stevejalim mentioned this pull request Sep 22, 2026

Update toolchain (Fix #441) #444

Merged

stephaniehobson force-pushed the 79--github-actions-ci branch 2 times, most recently from f2ad5c9 to b224c69 Compare September 22, 2026 17:52

stephaniehobson force-pushed the 79--github-actions-ci branch from b224c69 to 53cce11 Compare September 22, 2026 17:55

stephaniehobson force-pushed the 79--github-actions-ci branch 2 times, most recently from 49924b9 to fa97eea Compare September 29, 2026 02:52

Base automatically changed from 441--update-toolchain to main October 1, 2026 18:03

stephaniehobson force-pushed the 79--github-actions-ci branch 3 times, most recently from d1804e6 to e501cc5 Compare October 2, 2026 01:26

stephaniehobson marked this pull request as ready for review October 2, 2026 01:26

stephaniehobson force-pushed the 79--github-actions-ci branch from e501cc5 to 20e83f2 Compare October 2, 2026 02:38

stephaniehobson commented Oct 2, 2026

View reviewed changes

Revise execplan instructions

21e8570

stephaniehobson added a commit that referenced this pull request Oct 9, 2026

Record that the CI work replaces pull request #447 (#79)

0dbdd18

stephaniehobson force-pushed the 79--github-actions-ci branch from 20e83f2 to 0dbdd18 Compare October 9, 2026 03:24

stephaniehobson force-pushed the 79--github-actions-ci branch from ec5e797 to 95f3925 Compare October 9, 2026 03:33

stevejalim requested a lite review from Copilot October 13, 2026 15:02

Copilot started reviewing on behalf of stevejalim October 13, 2026 15:02

View session

stevejalim reviewed Oct 13, 2026

View reviewed changes

Copilot AI reviewed Oct 13, 2026

View reviewed changes

stevejalim approved these changes Oct 13, 2026

View reviewed changes

stephaniehobson added 2 commits October 15, 2026 10:14

Remove a link test that can no longer fail, and a stale PLANS.md claim (

14ea2d1

#79)

Compile CSS and bound job time in CI, and tidy link tests (#79)

0e34913

stephaniehobson merged commit 0fa80fd into main Oct 15, 2026
2 checks passed

Navigation Menu

Repository navigation

Add GitHub Actions CI workflow for lint and tests (#79) - #447

Add GitHub Actions CI workflow for lint and tests (#79)#447
stephaniehobson merged 4 commits into
mainfrom
79--github-actions-ci

stephaniehobson commented Sep 18, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

stephaniehobson Oct 2, 2026

Uh oh!

stevejalim Oct 2, 2026

Uh oh!

stevejalim Oct 13, 2026

Uh oh!

stevejalim Oct 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

stevejalim left a comment

Uh oh!

stevejalim Oct 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,937 @@
		# Add a GitHub Actions workflow that lints and tests every commit and pull request

Conversation

stephaniehobson commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

One-line summary

Significant changes and points to review

Issue / Bugzilla link

Testing

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

stephaniehobson Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

stevejalim Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

stevejalim Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

stevejalim Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

stevejalim left a comment

Choose a reason for hiding this comment

Uh oh!

stevejalim Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stephaniehobson commented Sep 18, 2026 •

edited

Loading