Prepare release v1.0.0 - #57
Conversation
051bb18 to
5310985
Compare
Daverball
left a comment
There was a problem hiding this comment.
Looks good to me apart from the pyright failures on the CI due to the missing sphinx dependency in that tox environment. mypy only seems to succeed because the mypy configuration currently still ignores errors in dectate.sphinxext, so it's not in sync with the pyright config that no longer excludes that module.
| [[tool.mypy.overrides]] | ||
| module = "dectate.sphinxext.*" | ||
| ignore_errors = true |
There was a problem hiding this comment.
This seems to be inconsistent with the pyright config, but pyright also currently fails to type check. I assume it's missing the sphinx dependency in that specific tox environment.
f84739c to
5dd5409
Compare
|
I fixed also the scenarios folder. I was still using the old API before dectate 0.12. |
0fa17ca to
e3403fd
Compare
e3403fd to
7730029
Compare
0dea883 to
86139f5
Compare
|
I'm not thrilled about the prospect of adding import-time overhead for some typing-only symbols only so the docs can cross reference them. Maybe we build the docs with Python 3.15 and leverage the new lazy imports, like this: if TYPE_CHECKING:
from collections.abc import Callable, Sequence
elif sys.version_info >= (3, 15):
__lazy_modules__ = ["collections.abc"]
from collections.abc import Callable, SequenceOr if we're fine with changing the annotations from if TYPE_CHECKING:
from collections import abc
elif sys.version_info >= (3, 15):
abc = __lazy_import__("collections.abc")That would also let you deal with the symbols that currently lead to circular references, since sphinx won't inspect the annotations until the modules have fully loaded, so the lazy imports won't trigger until that happens. |
|
I guess you're right. I will take a look. BTW I made the changes for |
|
A PR definitely can't hurt if you want a second pair of eyes looking over the changes, but I'll leave it up to your judgement. |
86139f5 to
7311254
Compare
|
I added a doc-build-only shim add the end of |
|
That works too, yeah. Can't we use the same trick to resolve the circularity issue with |
7311254 to
9a5cf20
Compare
|
Yep - I was able to fix |
@Daverball Can you take a look?