Skip to content

fix: show stored tickers when token info is unavailable - #26

Merged
erubboli merged 1 commit into
mainfrom
fix/favourite-ticker-fallback
Oct 15, 2026
Merged

erubboli merged 1 commit into
mainfrom
fix/favourite-ticker-fallback

Conversation

@erubboli

Copy link
Copy Markdown
Member

Summary

  • Favourites now render the ticker stored in the user's preference when the on-chain token info lookup fails (e.g. wallet daemon unreachable) instead of a bare ??? placeholder.
  • /api/prefs hardening while favourites became user-visible output: reject tickers containing control or bidi-override characters; legacy plain-string entries are normalized to the {tokenId, ticker} object shape on both read and write.
  • Re-pinning an unresolvable token stores a short-id placeholder instead of the literal ???.

Test plan

  • tsc --noEmit clean; 877 tests green (74 files) incl. new daemon-down fallback test and bidi/control ticker rejection; astro build OK.
  • Independent security review: 0 blockers, 0 majors; 4 minors all addressed in this PR.

@erubboli
erubboli merged commit f647e6e into main Oct 15, 2026
14 checks passed
@erubboli
erubboli deleted the fix/favourite-ticker-fallback branch October 15, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant