Repository navigation
Propagate sub-package failures from build/bin/all.js - #1888
Closed
Trivikram Kamat (trivikr) wants to merge 1 commit into
Closed
Trivikram Kamat (trivikr) wants to merge 1 commit into
Trivikram Kamat (trivikr) wants to merge 1 commit into
Conversation
all.js ran `npm <script>` in each sub-package via spawnSync but discarded the result. Since `npm test`, `npm run lint`, `npm run clean` and `npm run audit:all` all go through this script, failing tests or lint errors in a sub-package still exited 0 and CI stayed green. Check the spawnSync result and exit non-zero on the first failure, including spawn errors and termination by signal.
Trivikram Kamat (trivikr)
marked this pull request as draft
October 14, 2026 15:11
Author
|
Heads-up: with this change, CI now surfaces failures that were previously swallowed. When running The fix for that is in #1889. I'd suggest merging #1889 first (or together with this one) so CI doesn't start failing randomly once this lands. |
Member
|
Got fixed yesterday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all.js ran
npm <script>in each sub-package via spawnSync but discarded the result. Sincenpm test,npm run lint,npm run cleanandnpm run audit:allall go through this script, failing tests or lint errors in a sub-package still exited 0 and CI stayed green.Check the spawnSync result and exit non-zero on the first failure, including spawn errors and termination by signal.