Repository navigation
Fix line offsets when incremental edits join CRLF - #1882
Merged
Dirk Bäumer (dbaeumer) merged 3 commits intoOct 20, 2026
Merged
Dirk Bäumer (dbaeumer) merged 3 commits into
Dirk Bäumer (dbaeumer) merged 3 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The targeted invalidation is correct and the regression tests cover both boundaries and batched updates.
0 open findings
What changed in this PR
Fixes stale line offsets when incremental edits create CRLF pairs across edit boundaries.
Changes:
- Invalidates cached offsets when edits join CRLF.
- Adds regression coverage for insertions, removals, and batched edits.
| File | Description |
|---|---|
textDocument/src/main.ts |
Detects boundary-spanning CRLF pairs and rebuilds offsets. |
textDocument/src/test/textdocument.test.ts |
Tests affected line and position APIs. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dirk Bäumer (dbaeumer)
enabled auto-merge (squash)
October 14, 2026 11:58
Dirk Bäumer (dbaeumer)
approved these changes
Oct 14, 2026
Anthony Kim (anthonykim1)
approved these changes
Oct 20, 2026
roblourens
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
An incremental edit can join a carriage return and line feed across the edit boundary while leaving the cached line offsets stale. For example, inserting
\nat line 1, character 0 ina\rbproducesa\r\nb, butlineCountreturns 3 instead of 2. Line and position lookups then disagree with a fresh document containing the same text.Fix
Invalidate cached line offsets when an edit leaves a CRLF pair across either edit boundary. The next lookup rebuilds them from the updated content; other edits retain the incremental update path.
Verification
b4f995b(3 !== 2) and passes with this fix. It covers insertion at either side of the boundary, removal of an intervening character, and a batch of edits.textDocument:npm run all(63 tests passing).npm run symlink,npm run compile,npm run lint, andnpm testpassed locally on Node 22.PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64.