Repository navigation
Treat connection close during stop() as handled - #1782
Open
Lionel Henry (lionel-) wants to merge 4 commits into
Open
Lionel Henry (lionel-) wants to merge 4 commits into
Lionel Henry (lionel-) wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The notification regression needs automated test coverage.
1 open finding
What changed in this PR
Suppresses user-visible connection-close notifications when closure occurs during stop().
Changes:
- Treats the
Stoppingstate as handled. - Retains output-channel logging without showing a toast.
| File | Description |
|---|---|
client/src/common/client.ts |
Handles connection closure during shutdown without notification. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| this._connection = undefined; | ||
| // `Stopping` counts as handled. The application asked for the close via `stop()`, | ||
| // and `closed()` was skipped above so the handler had no chance to set `handled`. | ||
| const handled = this.$state === ClientState.Stopping || handlerResult.handled === true; |
Dirk Bäumer (dbaeumer)
requested changes
Oct 14, 2026
Dirk Bäumer (dbaeumer)
left a comment
Dirk Bäumer (dbaeumer)
left a comment
Member
There was a problem hiding this comment.
See the Copilot review comment.
Author
|
Dirk Bäumer (@dbaeumer) I've added a test |
Lionel Henry (lionel-)
requested review from
Dirk Bäumer (dbaeumer)
and
a balanced review from Copilot
October 14, 2026 17:17
Dirk Bäumer (dbaeumer)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've hit a case where our
closed()handler, meant to prevent user-visible toast notifications, was not invoked by languageclient. Our Linux users (likely due to some weird platform-specific race) consistently see a toast notification on restart due to this (posit-dev/positron#7593).I think this is because the
closed()handler is not called when the client is already stopping: https://github.com/lionel-/vscode-languageserver-node/blob/f5e23e29b76c42fad882aa84933d46ba9b412183/client/src/common/client.ts#L1827-L1833. This prevents our handler from settinghandledtotrue.The fix proposed here is to treat a client that's already stopping as "handled", this way a toast notification isn't displayed.