Repository navigation
test: port the upstream tests by registry id - #3274
Closed
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Closed
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
Port every test in upstream's tests/registry.md at b335271c (the tests
are those of 6bbe2475b, its parent) to tests/{async,sync}/{page,library},
named after its id and title, or list it in tests/upstream_not_ported.txt
with the reason. scripts/check_test_registry.py checks this in CI.
The test assets, the test server and the certificates are upstream's.
The older tests move to tests/{async,sync}/legacy, with the changes that
the new files need: paths, keyboard.html, consolelog.html, the
certificate, the response headers of the server, and page.pause() in
upstream's test mode.
The ports are not collected yet: they run with the line-by-line port of
the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/registry.md(at b335271c, the driver's rev) totests/{async,sync}/{page,library}, or list it intests/upstream_not_ported.txt.scripts/check_test_registry.pychecks this in CI.tests/{async,sync}/legacyand remain the only tests that run. The ports run with the line-by-line port of the client, in a follow-up.