CHORE: Accept stable ABI Rust wheels - #804
Draft
gargsaumya wants to merge 2 commits into
Draft
gargsaumya wants to merge 2 commits into
gargsaumya wants to merge 2 commits into
Conversation
PR Performance ReportPerformance could not be assessed. Build provenance validation failed. No result is available. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates mssql-python-rs installers to select stable-ABI cp310-abi3 wheels across supported platforms.
Changes:
- Updated Bash and PowerShell wheel-selection patterns.
- Updated fixtures and installer contract tests.
| File | Description |
|---|---|
tests/test_037_rs_wheel_download.py |
Updates fixtures and validates stable-ABI selection. |
eng/scripts/install-mssql-py-core.sh |
Selects stable-ABI wheels on Unix platforms. |
eng/scripts/install-mssql-py-core.ps1 |
Selects stable-ABI wheels on Windows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The transport pin conflicts with the contract test’s expected 0.1.0 version and must be reconciled.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
| @@ -1 +1 @@ | |||
| 0.1.0 No newline at end of file | |||
| 0.1.0-dev.20260921.176911 No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Update the mssql-python-rs installers to select the stable-ABI
cp310-abi3wheel for each target platform, with focused tests for the new wheel-selection contract.Validation:
mssql-python-rs-wheels0.1.0-dev.20260921.176911(distribution remainsmssql-python-rs==0.1.0).mssql_python_rs-0.1.0-cp310-abi3-win_amd64.whlfrom NuGet transport0.1.0-dev.20260921.176911.mssql-python1.15.0 andmssql-python-rs0.1.0 passpip checkand import from the clean venv.tests/test_000_dependencies.pyandtests/test_037_rs_wheel_download.py: 44 passed, 3 skipped.Producer: microsoft/mssql-rs#624
ADO validation: https://dev.azure.com/sqlclientdrivers/mssql-rs/_build/results?buildId=176911