Repository navigation
Remove dead code in core and ui.chat - #475
Open
Lars Vogel (vogella) wants to merge 1 commit into
Open
Lars Vogel (vogella) wants to merge 1 commit into
Lars Vogel (vogella) wants to merge 1 commit into
Conversation
Drops the uncalled private ActionBar.selectFile(), an unused constant in CustomChatModeManager and unused imports in several chat classes. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Lars Vogel (vogella)
requested review from
Ethan Hou (ethanyhou),
Sheng Chen (jdneo) and
xinyi-gong
as code owners
October 6, 2026 15:18
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Static reference checks support this behavior-preserving cleanup, with no unresolved findings; builds and tests were not run.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unused code from the core and chat UI components without changing behavior.
Changes:
- Deletes the unused
ActionBar.selectFile()method; file selection remains handled byAddContextButton. - Removes an unused constant and unused imports.
| File | Description |
|---|---|
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/JavaDebuggerToolAdapter.java |
Removes an unused import. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/services/ReferencedFileService.java |
Removes an unused import. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/services/AgentToolService.java |
Removes unused imports. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ModelPickerGroupsBuilder.java |
Removes unused imports. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/BaseTurnWidget.java |
Removes unused imports. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ActionBar.java |
Deletes the unused file picker method and associated imports. |
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/chat/service/ICustomModeService.java |
Removes an unused import. |
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/chat/CustomChatModeManager.java |
Removes the unused SEPARATOR_PREFIX constant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes code that nothing references: the private
ActionBar.selectFile()method, which has no callers (file selection for chat context is handled byAddContextButton), together with the imports only it used, the unusedSEPARATOR_PREFIXconstant inCustomChatModeManager, and unused imports in several chat classes. There is no behavior change; the cleanup just makes these classes shorter and easier to read.