Repository navigation
Drop obsolete ui.terminal.tm bundle and dynamic terminal bundle loading - #471
Draft
Dietrich Travkin (travkin79) wants to merge 17 commits into
Draft
Dietrich Travkin (travkin79) wants to merge 17 commits into
Dietrich Travkin (travkin79) wants to merge 17 commits into
Conversation
Avoid "OSGi access rules not enforced by classpath access rules, which can lead to classloading errors at runtime."
Build the new target file for terminal.tm bundle (2024-12.target) similar to 2025-12.target and update docs.
See review comment microsoft#368 (comment)
Add separate LSP4E update site to target definition so that we can increase the LSP4E version without having to lift the Eclipse version.
This way, we'll always offer the right version of LSP4E and LSP4J bundles on our own update site.
…vider The 2025-12 target aggregates junit-jupiter versions up to 6.x. With only a minimum version constraint, ui.jobs.test resolved JUnit 6.x, which is outside Tycho 4.0.13's provider ranges, causing 'Could not determine test framework provider'. Bound junit-jupiter api/engine/params to [5.12.0,6.0.0) and add the engine bundle so the standalone test resolves a consistent 5.x set. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Make com.microsoft.copilot.eclipse.ui.terminal an ordinary plugin instead of an embedded JAR installed at runtime. Remove the obsolete code for dynamically installing terminal bundles via TerminalServiceManager . Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to PR #368.
PR #368 upgrades the target platform to Eclipse 2025-12 and JDK 21.
As a follow-up task, this PR removes:
com.microsoft.copilot.eclipse.ui.terminal.tmbundlecom.microsoft.copilot.eclipse.ui.terminalor legacycom.microsoft.copilot.eclipse.ui.terminal.tm), since we'll now always load the modern terminal bundle using the Eclipse plug-in dependency mechanism.