Skip to content

Consolidate built-in chat mode discovery on top of PR #452 - #468

Merged
Sheng Chen (jdneo) merged 2 commits into
jdneo-preferences-01-nonblocking-loadingfrom
copilot/jdneo-preferences-01-nonblocking-loading
Sep 30, 2026
Merged

Sheng Chen (jdneo) merged 2 commits into
jdneo-preferences-01-nonblocking-loadingfrom
copilot/jdneo-preferences-01-nonblocking-loading

Conversation

Copilot AI commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

PR #452 loads chat preferences and discovers modes asynchronously. This incremental refactor consolidates built-in mode discovery without changing that lifecycle.

  • Discovery: Move RPC loading, allowed-name filtering, InlineAgent exclusion, and conversion handling into BuiltInChatModeManager. Retain its snapshot and lookup methods; remove BuiltInChatModeService.
  • Integration: Keep the asynchronous UI call and use the manager’s sole loading entry point:
    BuiltInChatModeManager.INSTANCE.loadBuiltInModes(lsConnection)
  • Coverage: Move the service test to the manager and add cases for filtering, null connections, conversion failures, and RPC failures.

Co-authored-by: jdneo <6193897+jdneo@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor built-in chat mode implementation on top of PR #452 Consolidate built-in chat mode discovery on top of PR #452 Sep 30, 2026
@jdneo
Sheng Chen (jdneo) marked this pull request as ready for review September 30, 2026 05:04
@jdneo
Sheng Chen (jdneo) merged commit c2e30c5 into jdneo-preferences-01-nonblocking-loading Sep 30, 2026
1 check passed
@jdneo
Sheng Chen (jdneo) deleted the copilot/jdneo-preferences-01-nonblocking-loading branch September 30, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants