Repository navigation
Fix some bugs found during #216 - #230
Merged
Merged
Conversation
majst01
requested review from
Gerrit91 and
mwennrich
and removed request for
a team
October 16, 2026 08:31
majst01
commented
Oct 16, 2026
|
|
||
| func getHost() (string, error) { | ||
| c, err := netconf.New(network.GetLogger(), network.MetalNetworkerConfig) | ||
| c, err := netconf.New(slog.Default(), network.MetalNetworkerConfig) |
Contributor
Author
There was a problem hiding this comment.
using default logger here, networker will get removed later anyway
mwennrich
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a bugfix only PR extracted from #216
Used AI-Tools ✨