feat: add reusable Cloudflare Pages deploy and deploy-run resolver - #8
Merged
Merged
Conversation
cloudflare-pages-deploy deploys any built artifact; resolve-deploy-run outputs the commit to promote; hugo-ci gains a ref input. Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
added
the
mark-ready-when-ready
github-actions
Bot
removed
the
mark-ready-when-ready
Environment secrets reach a reusable workflow's job only when the caller inherits secrets. Also recommend restricting environments to main. Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
Add
cloudflare-pages-deploy.yaml, which deploys a built static site from an artifact to Cloudflare Pages inside a GitHub environment, andresolve-deploy-run.yaml, which finds the deploy run to promote and outputs its commit.hugo-ci.yamlgains arefinput so promote can rebuild that commit. Neither new workflow builds anything, so both work for any site; a caller composes them with its own build job.Proof it works
secrets: inherit. The docs and workflow comment now say so.Risk + AI role
Medium. These workflows deploy to production for callers. Claude Opus 5.5 wrote them.
Review focus
secrets: inherit, which zizmor flags. The docs explain why and recommend restricting each environment tomain, so a pushed branch can't run a modified workflow with the environment's secrets.resolve-deploy-runrefuses runs that aren't successful runs of the named deploy workflow on the expected branch.