Repository navigation
Fix installer compatibility with Windows PowerShell 5.1 - #72
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates the Windows installer for compatibility with Windows PowerShell 5.1 and PowerShell 7.
Changes:
- Adds robust architecture detection and validation.
- Expands installer testing across both PowerShell editions.
- Documents supported PowerShell versions.
| File | Description |
|---|---|
test/install-release.ps1 |
Adds architecture and failure-handling tests. |
README.md |
Documents PowerShell compatibility and version checks. |
install-release.ps1 |
Adds architecture resolution and fallback logic. |
.github/workflows/release.yml |
Extends release validation to both PowerShell editions. |
.github/workflows/ci.yml |
Tests the installer under both PowerShell editions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows installer fails before downloading anything in Windows PowerShell environments where RuntimeInformation.OSArchitecture is unavailable. Requiring PowerShell 7 would add an unnecessary installation prerequisite.
Changes
Validation
No changes to the Go application, terminal interface or release version.