Repository navigation
Fix console prompts hanging when isInteractive() is unreliable - #39
Merged
Merged
Conversation
Command::ask()/confirm()/secret()/choice()/multiChoice() relied solely on $input->isInteractive(), which reflects --no-interaction/-n and Symfony's own best-effort stdin check — observed returning true (i.e. "safe to prompt") on at least one real environment whose stdin would in fact never produce an answer, hanging the command indefinitely. Added canPrompt(), which also requires stream_isatty(STDIN); every prompt now falls back to its default immediately when either check fails, rather than attempting to read one. Found and reproduced while testing marrow/anvil's and marrow/ai-context's own interactive commands — both updated alongside this to use the new guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command::ask()/confirm()/secret()/choice()/multiChoice() relied solely on $input->isInteractive(), which reflects --no-interaction/-n and Symfony's own best-effort stdin check — observed returning true (i.e. "safe to prompt") on at least one real environment whose stdin would in fact never produce an answer, hanging the command indefinitely. Added canPrompt(), which also requires stream_isatty(STDIN); every prompt now falls back to its default immediately when either check fails, rather than attempting to read one. Found and reproduced while testing marrow/anvil's and marrow/ai-context's own interactive commands — both updated alongside this to use the new guard.