Skip to content

feat!: separate optional demos and expand runtime transform tools - #53

Open
manaporkun wants to merge 56 commits into
mainfrom
feat/modular-building-demo
Open

manaporkun wants to merge 56 commits into
mainfrom
feat/modular-building-demo

Conversation

@manaporkun

@manaporkun manaporkun commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Core stays independently installable, while the original showcase and four additional samples live in the optional Demos package. Existing sample GUIDs are preserved; users need to back up and remove old imports before importing the relocated showcase or Lamp Assembly.

The branch adds Precision visuals, lifecycle and ownership fixes, opt-in group transform controls and bounded rotation. The optional samples share a UI Toolkit shell and include Level Editor, Modular Building, Lamp Assembly and a gallery. The release workflow freezes Core 4.0.0 and Demos 1.0.0 before testing and publishes only those tested files. An advanced main stops publication, and interrupted releases are revalidated from their original package source.

Consumer CI now installs the frozen packages through real UPM tarball and local Git routes, then checks use, customization, native players, upgrade and removal. The approved coverage is five full journeys and three installation/build/player probes across Unity 2021.3.45f1 and Unity 6, both input backends and Built-in/URP. Frozen fixtures, package hashes, real window input, rendered frames and exact test inventories prevent stale or partial evidence from passing.

November 2026 update: the original plan to run the 2021 journeys on Unity 2021.3.0f1 is not achievable in headless CI with a Personal account. Every activation route was measured failing with redacted licensing output retained in job artifacts: the Editor's bundled 1.9 licensing client misreports a machine-mismatched ULF as activated (so the binding fallback never fires), a current client assigns a seat whose entitlement this Editor's licensing module then rejects, and the Editor's own account activation dies at Unity's deprecated legacy endpoint. With owner approval, the 2021 consumer profile now runs Unity 2021.3.45f1 — the final 2021.3 patch, also the compatibility-floor Editor — through the same GameCI action wrappers as Unity 6, and the minimum-activation prerequisite, licensing-client helper and receipt machinery are deleted. Declared 2021.3.0f1 support is unchanged; it rests on the recorded local macOS candidate validation at that exact version, the 2021.3.45f1 floor/consumer suites, and the narrow min-API lint. CI consumer journeys are not 2021.3.0f1 evidence and are not described as such.

On 25dfe41, all 141 local Python tests, static checks and package-boundary verification pass. Run 42596677952 (attempt 3) is fully green: Remote Core/Demos jobs for both input backends, the Unity 2021.3.45 compatibility floor, minimum API lint, commit hygiene, package validation and all eight Linux consumer journeys pass; the only skips are check-reporting jobs and the main-only publish job. The matrix's first runs found and fixed several latent fixture/driver defects stage by stage (coverage-flag CLI rejection, xdotool sync hang, disabled-handle capture, World/Local key sequence, distinct consumer prefab size, Unity 6 symbol ambiguity, handle-less showcase verification, upgrade prefab-size expectation). Two full journeys initially stopped on Unity's per-account activation rate limit (143.002) after the day's repeated runs and passed unchanged when rerun individually. Earlier Mac and WebGL smoke evidence is documented in the development handoff, and the owner confirmed physical Mac trackpad validation.

Keep this draft until final owner review is complete. Main automatically publishes Core and updates the public WebGL showcase on merge. Asset Store packaging and presentation remain separate work.

BREAKING CHANGE: Core no longer distributes the original sample. Install the optional Demos package explicitly and follow the import cleanup instructions to avoid duplicate GUIDs and assemblies.

Eotel and others added 30 commits October 23, 2026 14:05
Add a responsive Level Editor sample, Precision handles, group rotation and uniform scaling. Harden handle ownership and lifecycle cleanup, and verify compatibility across Unity input backends.

Document validation and the next demo scenarios for continued development.

BREAKING CHANGE: samples move from Core into the separately installed optional demos package. Existing imported sample copies require explicit migration.
@gitguardian

gitguardian Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
39825156 Triggered Generic High Entropy Secret 395a256 ci/test_consumer_project.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@manaporkun
manaporkun marked this pull request as ready for review November 15, 2026 15:06
@manaporkun

Copy link
Copy Markdown
Owner Author

CI investigation for the two failed consumer jobs on 9613aad (run 43728009379): both failures are a Unity account/license activation lockout, not a code failure. No code fix is needed; the failed jobs will be re-run (gh run rerun 43728009379 --failed) once the run completes.

Identical decisive lines in both job logs (2021-legacy tarball job 132856778875 at stage gallery-build; 6-legacy tarball job 132856778852 at stage sample-LevelEditor-build):

[Licensing::Client] Error: Code 400 while processing request (status: Machine bindings don't match)
Failed getting authentication token. Unauthorized: {
##[error] Unity rejected the account credentials, or wants a second factor.
##[error]Build failed with exit code 1
ValueError: Editor never initialized the frozen consumer bootstrap

Why this is infra, not 9613aad:

  • The delta of 9613aad vs the previous green run (42693565286 on 002ee20) is two metadata files (one m_EditorClassIdentifier string, one folder .meta). Nothing in it can affect Unity account authentication, which fails before the Editor even starts.
  • The ValueError from ci/consumer-project.py (after_stage) is the downstream symptom: activation was rejected, so the Editor never launched and never wrote the stage bootstrap log.
  • In the same run on the same commit, Tests (input 0/1), Demos (input 0/1) and Consumer (2021-legacy, git, probe) already passed, and both failing jobs had completed many consumer stages (activations included) before tripping the limit in the same minute (~15:31Z) — Unity rate-limited the shared account after dozens of per-stage activate/return cycles (User reaches maximum same user attempt retry count, code 143.002). This exact signature previously hit run 42596677952 and cleared on rerun.

Next: wait for run 43728009379 to finish (5 consumer jobs still running/queued), then gh run rerun 43728009379 --failed only. If activation trips 143.002 again immediately, wait out the lockout window before re-running — no code change will affect it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants