feat(jdbc): report live SQLite version from sqld via sqlite_version() - #21
Merged
Merged
Conversation
Previously getDatabaseProductVersion(), getDatabaseMajorVersion(), and
getDatabaseMinorVersion() in LibsqlDatabaseMetaData returned hardcoded
values ("3.0", 3, 0). They now lazily execute SELECT sqlite_version()
against the connected sqld instance on first call, cache the result, and
parse major/minor components from the version string (e.g. "3.46.1").
A fallback to "3.0" is retained in case the query fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously
getDatabaseProductVersion(),getDatabaseMajorVersion(), andgetDatabaseMinorVersion()inLibsqlDatabaseMetaDatareturned hardcoded values ("3.0",3,0), regardless of the actual SQLite version running inside the connected sqld instance.Changes
resolveDatabaseProductVersion()helper that lazily executesSELECT sqlite_version()against the server on first call and caches the result on the metadata object.getDatabaseProductVersion()now returns the real version string (e.g."3.46.1").getDatabaseMajorVersion()/getDatabaseMinorVersion()parse their respective components from that string."3.0"/3/0is retained if the query fails for any reason.Testing
spotless:applyapplied;spotless:checkpasses.mvnw test -pl libsql-jdbcpasses.