Repository navigation
chore: bump com.mparticle:android-media in /kits/adobemedia/adobemedia-3 - #968
dependabot[bot] wants to merge 1 commit into
Conversation
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 1.4% (16,315 of 16,550 baseline Java LOC left to convert). 121 Java files and 47 Kotlin files in scope. |
Binary compatibility
Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
I reviewed this PR and found no bugs in the diff. One upstream change is worth a human check before merge: the android-media 1.5.4 notes list a fix for a "StreamType.LIVE_STREAM typo", and AdobeKit.kt:401 still matches on StreamType.LIVE_STEAM. If upstream renamed that constant without keeping the old name, or changed its value, the kit will fail to compile or will stop mapping live streams. A green root build doesn't cover kits, so please confirm with the kit build (-c settings-kits.gradle).
What was reviewed:
- The one-line
apibump ofcom.mparticle:android-mediafrom 1.5.0 to 1.5.6 inkits/adobemedia/adobemedia-3/build.gradle. Because it is declared withapi, consumers of the kit get the new version too. - How the kit uses the library's
StreamTypeconstants, compared with the upstream changes between 1.5.1 and 1.5.6. I couldn't check the upstream source from here.
Extended reasoning...
The change is a single dependency version bump in the Adobe Media kit's build.gradle and touches no security-sensitive surface. I deferred because the kit's getStreamType() in AdobeKit.kt references StreamType.LIVE_STEAM, and the upstream 1.5.4 release notes describe a fix to that constant's typo. That could be a source-breaking rename or a change in value, and I couldn't verify it against the upstream source. Root CI doesn't build kits, and the repo's CODEOWNERS assigns all paths to the SDK team.
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2512, "baseline_install_bytes": 7529, "core_dex_bytes": 221736, "core_download_bytes": 123969, "core_install_bytes": 131220}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 221736, "core_download_bytes": 123977, "core_install_bytes": 131227}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4171256, "kit_download_bytes": 2548256, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9293004, "sdkplus_download_bytes": 7985900, "sdkplus_install_bytes": 8165359}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4171256, "kit_download_bytes": 2548259, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9293004, "sdkplus_download_bytes": 7985897, "sdkplus_install_bytes": 8165359} |
Bumps [com.mparticle:android-media](https://github.com/mparticle/mparticle-android-media-sdk) in `/kits/adobemedia/adobemedia-3` from 1.5.0 to 1.5.6. Updates `com.mparticle:android-media` from 1.5.0 to 1.5.6 - [Release notes](https://github.com/mparticle/mparticle-android-media-sdk/releases) - [Changelog](https://github.com/mParticle/mparticle-android-media-sdk/blob/main/CHANGELOG.md) - [Commits](mParticle/mparticle-android-media-sdk@v1.5.0...v1.5.6) --- updated-dependencies: - dependency-name: com.mparticle:android-media dependency-version: 1.5.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: shared-gradle-dependencies/com.mparticle:android-media ... Signed-off-by: dependabot[bot] <support@github.com>
241bf6f to
b1a3cfb
Compare
Bumps com.mparticle:android-media in
/kits/adobemedia/adobemedia-3from 1.5.0 to 1.5.6.Updates
com.mparticle:android-mediafrom 1.5.0 to 1.5.6Release notes
Sourced from com.mparticle:android-media's releases.
... (truncated)
Changelog
Sourced from com.mparticle:android-media's changelog.
... (truncated)
Commits
4040469chore: 1.5.6 (release)228a831fix: handle ad_break_id key in the ad Summary event (#71)dad43ebfix: Correct the mapping of the mediaContentId key in the segment summary eve...2a3a225chore: 1.5.5 (release)497af13fix: Pause mediaContentTimeSpent when logMediaContentEnd is triggered (#70)7cc7c46chore: 1.5.4 (release)b696dd7fix(typo):StreamType.LIVE_STREAMtypo (#65)503f83fchore: 1.5.3 (release)74f9cd4chore: 1.5.3 (release)ead941dci: Update to pin conventional commits version (#69)