Conversation
JtsMultiShapeBuilder re-wrapped homogeneous children via makeShapeFromGeometry, which re-validated geometries that multi* builders already accept via makeShape. Return a lone child unchanged and use makeShape for homogeneous Multi* merges. Fixes locationtech#232 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
dsmiley
reviewed
Sep 28, 2026
| } | ||
|
|
||
| return makeShapeFromGeometry(geometryFactory.buildGeometry(geoms)); | ||
| if (shapes.size() == 1) { |
Contributor
There was a problem hiding this comment.
It's not clear why this check is here, relative to the fix. If this is an unrelated optimization, it could go at the start of build(); yes?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MULTIPOLYGONis accepted alone but rejected inside aGEOMETRYCOLLECTION(Validation for self-intersection WKT Multipolygon fails at the WKTReader, while works when wrapped in aGEOMETRYCOLLECTION#232).JtsMultiShapeBuildernow returns a single child shape unchanged (no re-wrap/re-validate) and usesmakeShapefor homogeneousMulti*merges, matchingJtsMultiPolygonBuilderand siblings.JtsSpatialContext.GEOand both WKT strings from the issue.Test plan
mvn test(full suite, JDK 17)MULTIPOLYGONand wrappedGEOMETRYCOLLECTIONboth parse successfully onJtsSpatialContext.GEOContributor notes
Fixes #232