Push mknov upstream - #2520
Push mknov upstream#2520hamedhani1998 wants to merge 2 commits into
Conversation
Add source plugin for mknov.com (مملكه الروايات), an Arabic novel site. Features: - popularNovels, parseNovel, parseChapter, searchNovels, resolveUrl - Decodes the site's font-cmap obfuscation (19 rotating cipher maps) - Handles Next.js RSC flight payload extraction for chapter content Co-Authored-By: Claude Code <noreply@anthropic.com>
TypeScript downlevels [...content] to a __spreadArray helper that requires a real array and throws "Cannot use 'in' operator" on strings during parseChapter. Switch to Array.from which iterates strings safely. Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
Could you remove this?
There was a problem hiding this comment.
Hi — this .js is the compiled output of plugins/arabic/mknov.ts. I only committed it (as a separate "chore" commit) so the plugin could be loaded and tested in the app immediately, without pulling from a build step first.
The file itself is not required: the repo .gitignore already lists .js, and none of the other plugins under plugins/arabic/ commit compiled output — the build generates it from the .ts. I will remove it from the PR so it only ships the TypeScript source.
There was a problem hiding this comment.
Hi — this .js is the compiled output of plugins/arabic/mknov.ts. I only committed it (as a separate "chore" commit) so the plugin could be loaded and tested in the app immediately, without pulling from a build step first.
The file itself is not required: the repo .gitignore already lists .js, and none of the other plugins under plugins/arabic/ commit compiled output — the build generates it from the .ts. I will remove it from the PR so it only ships the TypeScript source.
There was a problem hiding this comment.
Done — the compiled .js is removed. The PR now ships only plugins/arabic/mknov.ts (+ the icon), same as the other plugins.
dbcb063 to
35a7985
Compare
This branch has not been deployed
3 participants
Checklist
type(scope): description(e.g.feat(<generator>): add new source)