Repository navigation
Conversation
Fixes case where all candidate commpaths were added to localprefix prior to vetting.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selected commpath should be added to localprefix. Testing the multiple commpaths case (where some or all of the candidate commpaths could be unusable) flushed out a bug where all of the candidate commpaths were getting added to localprefix, including
/(which was intended to be discarded by the selection process). That led to all files being considered local, and several obscure test failures.On a related note: the cachepath should also be added to localprefix (to cover the pathological case of a user keeping local files in Spindle's cache).