Repository navigation
feat: support flintlock v0.16.0 - #12
Merged
Merged
Conversation
Set the flintlock api and client modules to the v0.16.0 commit (ae2417facf95). Set the client module to Go 1.26. Add the ServerInfo method to the client. The MicroVMClient interface of v0.16.0 has this method. Add the AllowGuestAgent and CPUConfig fields to the VMSpec type. CPUConfig has the FeaturesToEnable and KVMCapabilitiesToDisable fields. Make the deepcopy code again with controller-gen. Set controller-gen to v0.23.0 and set CI to Go 1.26.x.
Set the microvm service to Go 1.26 and to the v0.16.0 flintlock api and client modules. Set the controller-pkg client and types modules to commit 13bd81e. Send the AllowGuestAgent and CPUConfig fields to the flintlock API. Add tests for the new fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After this change, the 3 modules build with flintlock v0.16.0.
The flintlock repository does not tag the api and client submodules. Thus the modules use the pseudo-version of the v0.16.0 commit (ae2417facf95).
Changes
client
types/microvm
services/microvm
Build and CI
-compat=1.19flag fromgo mod tidy.Notes
grpc.Dial. grpc 1.84 shows this function as deprecated. grpc will keep this function in all 1.x versions. This change does not replace it.make alldoes not operate before this change and after this change. Thefmt-%rule has amocks-%prerequisite. There is nomocks-%rule.client.Clientinterface must add a ServerInfo method. The interface includes the flintlock MicroVMClient interface.Tests
go build,go vet, andgo mod tidygive no errors for the 3 modules.go test ./...in services/microvm gives no errors. The test suite has 4 new cases for the new fields.