TPT-4671: Generate SSH keys in process for integration tests - #742
Open
zliang-akamai wants to merge 3 commits into
Open
zliang-akamai wants to merge 3 commits into
zliang-akamai wants to merge 3 commits into
Conversation
Drop the ssh-keygen subprocess so the suite does not need OpenSSH on the host. Add cryptography as an int-test extra.
zliang-akamai
added
the
testing
zliang-akamai
marked this pull request as ready for review
September 14, 2026 17:52
zliang-akamai
requested review from
mawilk90 and
yec-akamai
and removed request for
a team
September 14, 2026 17:52
mawilk90
previously approved these changes
Sep 16, 2026
zliang-akamai
dismissed
mawilk90’s stale review
September 23, 2026 19:01
The merge-base changed after approval.
zliang-akamai
requested review from
a team,
mawilk90 and
psnoch-akamai
and
a lite review from Copilot
and removed request for
a team
September 24, 2026 21:00
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain.
Review effort: Lite
Findings: None
What changed in this PR
This pull request replaces the integration tests’ dependency on ssh-keygen with in-process Ed25519 key generation.
Changes:
- Generates OpenSSH-compatible keys using
cryptography. - Adds
cryptographyto integration-test dependencies.
| File | Summary |
|---|---|
test/integration/conftest.py |
Replaces subprocess-based key generation. |
pyproject.toml |
Adds the required integration dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Integration tests currently create SSH keys by shelling out to
ssh-keygen, which fails on hosts that do not have OpenSSH installed. Generate Ed25519 keys in process with cryptography so the suite no longer depends on that host binary.✔️ How to Test