Repository navigation
fix(native): draw the Pulls quick filters as ghost tabs that share the list's width - #931
Merged
Merged
Conversation
…e list's width The default tabs were the heaviest control on the list island, taller than the search field above them, and with a monospace interface font the last filter ran past the island's edge. The ghost variant, the dock's tabs, now fills a minimum width with equal triggers; the dock lays it out in a Rigid and keeps its own widths. A filter's count fades when it is empty and Failing's turns destructive when a check fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The All / Ready / Drafts / Failing filters over the Pulls list used the default Tabs: a filled h-9 track in text-sm, the heaviest control on the list island and taller than the search field above it. With a monospace interface font the last filter ran past the island's edge.
TabsVariantGhostfills a minimum width with equal triggers (flex-1 over a w-full list). The dock lays its tabs out in aRigid, so its Min.X is 0 and its triggers keep their own widths.Test plan
TestTabsGhostFillsAMinimumWidthEquallyfails before the change and passes afterTestFilterCountColorReadsTheStatenative/:gofmt -l .,go vet ./...,go test ./...-shotof Pulls on an isolated backend: the four filters fit the 320dp island in a monospace font, zero counts faded