Repository navigation
Conversation
The lifecycle descriptions tied idle to peer disconnection and shutdown, while the runtime preserves the current phase. Clarify immediate gossip startup for genesis, persisted state and checkpoint anchors so client implementers can follow the existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the sync lifecycle descriptions to match the existing runtime behavior.
Runtime behavior stays unchanged. The patch touches comments and docstrings in three source files.
Motivation
The previous lifecycle description associated idle with peer disconnection and shutdown. The network service removes disconnected peers while preserving the sync phase, and node shutdown stops service tasks while preserving that phase.
The node also enables immediate gossip startup for every store source. Describing this as exclusive to genesis validators can lead downstream clients to implement different startup behavior.
Validation
uv tool run --from just-bin just checkuv run --locked --group test pytest tests/node/sync/test_states.py tests/node/sync/test_service.py tests/node/networking/service/test_service.py tests/node/test_node.py --no-cov -q(126 passed)git diff --checkuv.lockunchanged.