docs: Explain non-blocking provider registration - #65
Open
kinyoklion wants to merge 1 commit into
Open
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
@cursor review |
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
kinyoklion
marked this pull request as ready for review
September 23, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenFeature Python SDK 0.10.0 made
api.set_providernon-blocking and addedapi.set_provider_and_wait, which changes when an application can rely on initialization having completed.set_providerreturns before initialization finishes, so early evaluations may fall backset_provider_and_waitRequirements
Related issues
None.
Implementation details
Verified in
openfeature/api.pyof the Python SDK:set_providerregisters withoutwait_for_init, whileset_provider_and_waitpasseswait_for_init=True. The provider's supported range (openfeature-sdk >=0.9.0,<1) includes releases with both behaviors, so the note describes the current SDK behavior rather than a provider change.No behavior change; documentation only. The paragraph sits next to the
start_waitdiscussion, so this may need a trivial rebase alongside the openstart_waitPR.Link to Devin session: https://app.devin.ai/sessions/a47abf28ecd44130917b9b5131287221
Open in Devin Desktop: https://app.devin.ai/desktop/session/a47abf28ecd44130917b9b5131287221?variant=devin
Requested by: @kinyoklion
Note
Overview
Documents how OpenFeature Python SDK provider registration behaves after
set_providerbecame non-blocking in SDK 0.10.0.The README Usage section adds a short note after the
start_waitexplanation:api.set_providerreturns before the LaunchDarkly provider finishes initializing, so early flag evaluations may see fallback values while the client connects. Apps that must not evaluate until init completes are directed toapi.set_provider_and_wait.No runtime or provider code changes—documentation only.
Reviewed by Cursor Bugbot for commit 3815238. Bugbot is set up for automated code reviews on this repo. Configure here.