fix!: Use None rather than zero for indefinite initialization waiting - #64
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Sep 16, 2026
Draft
Draft
Contributor
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
start_waitwith the OpenFeature provider spec (OFP), which requires a distinct non-duration value to request indefinite initialization waiting.start_wait=Nonenow requests an indefinite wait: the constructor does not block andinitializewaits until the data source becomes valid or fails permanently.start_wait=0no longer waits indefinitely; it waits nowhere, soinitializereports a failed initialization unless the client is already ready, and readiness is observed through provider events.initializereturns immediately with whatever the outcome is.0meaning "wait forever".Requirements
Related issues
None.
Implementation details
OFP requires that a positive start wait bound total construction plus initialization, that zero wait nowhere, and that indefinite waiting avoid construction-time blocking and instead wait during
initialize. Previously zero was overloaded to mean indefinite, leaving no way to express "no waiting at all".Noneis now passed toLDClientas a zero construction wait, with the waiting performed ininitializeagainst the data source status listener.Testing:
make test(88 tests) andmake lint(mypy) pass. New tests cover the zero and indefinite cases, including that the constructor does not block whenNoneis given.Link to Devin session: https://app.devin.ai/sessions/1fd3fcbfe79f482e8b58be29e8df2ffb
Open in Devin Desktop: https://app.devin.ai/desktop/session/1fd3fcbfe79f482e8b58be29e8df2ffb?variant=devin
Requested by: @kinyoklion