Skip to content

fix(tracing): require gen_ai. prefix in span filter - #1924

Open
fallintoplace wants to merge 1 commit into
langfuse:mainfrom
fallintoplace:fix/gen-ai-attribute-prefix
Open

fallintoplace wants to merge 1 commit into
langfuse:mainfrom
fallintoplace:fix/gen-ai-attribute-prefix

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Oct 4, 2026 •

Copy link
Copy Markdown

What

  • Fix gen_ai.* attribute matching in the span filter.

Why

  • Keys like gen_ai_custom currently cause unrelated spans to be exported.

Implementation

  • Require the gen_ai. prefix in is_genai_span.

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

Summary

The PR narrows GenAI attribute matching to the gen_ai. namespace.

  • Spans with lookalike keys no longer qualify for export solely because of those keys.
  • Parameterized tests cover rejected lookalikes and accepted namespaced attributes.

Reviews (1) · Last reviewed commit: "fix(tracing): require gen_ai. prefix in ..."

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant