Repository navigation
fix: fail supported PHP image builds below the Oct 2026 security release - #255
Open
AaronFeledy wants to merge 2 commits into
Open
AaronFeledy wants to merge 2 commits into
AaronFeledy wants to merge 2 commits into
Conversation
8.2-8.5 images now refuse to build unless PHP_VERSION is at least 8.2.35, 8.3.36, 8.4.27, or 8.5.12. Tags stay at -7 so existing installs pick the patched image up on lando rebuild. EOL images are unchanged.
✅ Deploy Preview for lando-php ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supported
devwithlando/phpimages (8.2, 8.3, 8.4, 8.5, apache and fpm) refuse to build unlessPHP_VERSIONis at least the 21 Oct 2026 security release:Those floors are
CVE-2026-109618andCVE-2026-109619. The check is aRUNimmediately after the finalFROM, so a stale base fails the build beforebuild-push-actionpushes.pull: trueis there so BuildKit resolves the official tag from the registry. Tags stay at-7. No plugin release. EOL images (8.1 and older) are unchanged and are not patched by this.Merging to
mainrebuilds and publishes the production tags. This PR only publishes-edgetags. Do not treat a green EOL job as a fix. After themainbuild, confirm the eight-7Hub digests moved andphp -von amd64 and arm64 meets the floor. Users pick the new image up withlando rebuild, notlando start.Test plan
8.2/8.3/8.4/8.5apacheandfpm-7differ from the 2026-06-24 publishesphp -von both platforms meets the floorNote
Medium Risk
Changes the supported image publish path to hard-fail on stale upstream PHP bases; misconfigured floors or upstream lag could block releases until bases meet the CVE patch levels.
Overview
Adds fail-closed minimum PHP version gates for supported
8.2–8.5Apache and FPM image builds so CI cannot publish images built from official bases below the Oct 2026 security releases (8.5.12, 8.4.27, 8.3.36, 8.2.35).Each affected Dockerfile now accepts optional
MIN_PHPand runs an earlydpkg --compare-versionscheck on$PHP_VERSIONright after the finalFROM, aborting the build before push if the base is too old. The build workflow passes per-matrixmin_phpviabuild-args, enablespull: trueso BuildKit refreshes upstream tags, and documents the change in the changelog. EOL8.1and older matrix entries are unchanged (no floor enforced).Reviewed by Cursor Bugbot for commit e059d89. Bugbot is set up for automated code reviews on this repo. Configure here.