Read a comma inside a quoted selector pattern as part of the pattern - #83
Open
peterbjohnson wants to merge 1 commit into
Open
peterbjohnson wants to merge 1 commit into
peterbjohnson wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three specs the agent wrote were refused with
A selector's comma separates its after clause from the rest, and '...' holds no after clause. Two shapes:ignore: Header, Table(two block types on one line) andignore: Para text~'^(Sheet|Note),|...'(a comma inside the quoted regex).in2lambda.spec._selectorsplits on the first comma to findafterbefore it reads the quotes.Parse quotes first: a comma inside a quoted pattern is part of the pattern. Then, where the text before the comma is not an
afterclause, refuse with a message that says what to write:Header, Table names two selectors on one line; write them as a YAML list under the role:followed by the two-line example. Keep the after-clause form as documented. Tests in tests/test_spec.py: a regex with a comma inside quotes parses;Header, Tableis refused with the list example;after Header text=Solutions, Parastill parses. docs/source/spec.md says a comma is the after separator only outside quotes. Done when the three specs from the sweep (in the ticket's shapes) parse or are refused with the list example.Workbench ticket t57.