Skip to content

Read a comma inside a quoted selector pattern as part of the pattern - #83

Open
peterbjohnson wants to merge 1 commit into
devfrom
wb/t57
Open

peterbjohnson wants to merge 1 commit into
devfrom
wb/t57

Conversation

@peterbjohnson

Copy link
Copy Markdown
Member

Three specs the agent wrote were refused with A selector's comma separates its after clause from the rest, and '...' holds no after clause. Two shapes: ignore: Header, Table (two block types on one line) and ignore: Para text~'^(Sheet|Note),|...' (a comma inside the quoted regex). in2lambda.spec._selector splits on the first comma to find after before it reads the quotes.
Parse quotes first: a comma inside a quoted pattern is part of the pattern. Then, where the text before the comma is not an after clause, refuse with a message that says what to write: Header, Table names two selectors on one line; write them as a YAML list under the role: followed by the two-line example. Keep the after-clause form as documented. Tests in tests/test_spec.py: a regex with a comma inside quotes parses; Header, Table is refused with the list example; after Header text=Solutions, Para still parses. docs/source/spec.md says a comma is the after separator only outside quotes. Done when the three specs from the sweep (in the ticket's shapes) parse or are refused with the list example.


Workbench ticket t57.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant