Compare every layout with convert by spec now that specs reach nested items - #82
Merged
Merged
Conversation
…each nested items (t54)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/fixtures/against_convert/ (t49) builds PartsSepSol, PartPartSolSol and PartSolPartSol by a commands.json each, because when it was written no spec reached a nested item and no command wrote a part's solution. Both are on dev now: t51 (nested blocks,
depthselector; tests/fixtures/specs/*_nested hold a spec per layout that assigns every block of the example) and t53 (draft part solution). The two nested folders' differs.txt still list the part solutions as differences tagged t53.Make the comparison run the spec route for all four layouts: replace each of the three commands.json with a spec.yaml (the *_nested fixture specs, copied or referenced), delete the t53 lines from the two differs.txt and the t53 bullet from the folder README, and let the test fail if any difference remains that the file does not name. Keep docx and crlf on their commands.json. Done when tests/test_against_convert.py passes with a spec.yaml in every layout folder and no differs.txt line tagged t53.
Workbench ticket t54.