Export the solution environment convert's own example uses - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in2lambda convert in2lambda/filters/PartsOneSol/example.tex PartsOneSolreturns both questions with no worked solution. The PartsOneSol filter matches a Div only whenpf.stringify(elem.content[0].content) == "Solution"; pandoc writes the example'ssolutionenvironment as a Div with classsolutionand no such text, so the filter never sees a solution. t49 found this by comparing the draft route with convert on the package's own example.Make the filter recognise the solution environment as pandoc writes it: a Div whose classes hold
solution, and keep the text match for documents that write aSolutionheading inside the div. Check the other three filters for the same test and fix them the same way. A test in tests/ runs each filter's example.tex throughrunnerand asserts every question that has asolutionenvironment in the source has a non-empty worked solution in the set. Done when the four examples export their solutions and the existing filter tests pass.Workbench ticket t52.