Repository navigation
feat(mirror): fail the run when upstream's clock goes stale - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
FRESH_KEY: mirror-updated-timestamp.txtfor lib v2.4.0'sfreshcheck (katoptra/lib#17). After every run the engine reads that file through the domain and fails the run when upstream's clock in it is 24 hours old, so a source that stops moving alerts through healthchecks.io before the upstream's own mirror monitor flags us at 28 hours. README gains the bullet and the failure mode.Merge order: inert until v2 moves to v2.4.0, and
task checkpasses against today's v2. Once v2 moves I'll push this repo's render update to this branch; merge after that.Test plan:
task checkpasses now; after v2.4.0, the first run's summary shows an "Upstream clock" row.