Skip to content

fix(discord): normalize URL-labelled links in response cards - #295

Merged
johoja12 merged 1 commit into
localfrom
fix/294-discord-url-labels
Nov 19, 2026
Merged

johoja12 merged 1 commit into
localfrom
fix/294-discord-url-labels

Conversation

@johoja12

Copy link
Copy Markdown
Owner

Discord response cards show redundant URL-labelled links such as [http://10.20.200.203/](http://10.20.200.203/) literally. The screenshot’s Demo app link is therefore cluttered instead of showing a clean direct link.

Normalize only identical HTTP(S) label/destination pairs to Discord autolinks, preserving the exact URL. The same rendering is applied to silent progress updates. Keep descriptive links, different destinations (including case-sensitive path mismatches), images, escapes and code examples unchanged. Support IPv4/IPv6, ports, query strings/fragments, parentheses, optional Markdown titles and angle-wrapped destinations. Inline and multiline code spans remain literal while links in surrounding prose are fixed. Existing mention and notification permissions are unchanged.

Fixes #294.

Validation: 319 tests passed across response formatting, rich input, artifact extraction, Full-mode integration and native UI. The screenshot and mixed-inline-code regressions failed before the fix. Typecheck, changed-source ESLint, source/test formatting, lockfile and whitespace checks passed. No new dependency.

Reference: Vercel’s maintained Discord adapter handles redundant URL labels as direct links. This change uses Discord’s explicit angle-bracket autolink form to keep punctuation/parentheses unambiguous and suppress previews consistently with existing cards.

Applies to newly rendered/refreshed output; no bulk rewriting of prior Discord messages. Existing broad-CI baseline failures are tracked in #287.

@johoja12
johoja12 merged commit e08d381 into local Nov 19, 2026
1 of 2 checks passed
@johoja12

Copy link
Copy Markdown
Owner Author

Shipped in PR #295, merged to local as e08d3810ec84b8d79fc0fe9acd3398197a00fc43 (feature commit 2cc1281e06d7b37d7cbf6b3a03eed5131af47faf). Production remains version 1.51.0; this was not a version release.

Validation: 319 focused tests passed, including red-before-fix screenshot and mixed-inline-code regressions. All pre-push static checks passed. Production build succeeded, service restarted and /api/sessions health passed. Fresh checks imported the deployed dist/discord-response-format.js and confirmed the exact screenshot produces **Demo app:** <http://10.20.200.203/> in response cards and silent progress output. Descriptive labels and inline code remain unchanged; progress notification flags remain silent.

Discord gateway is connected. All 16 pre-deployment session IDs and native conversation IDs were verified after startup settled. All original pane PIDs remain unchanged; all 17 current panes are alive (one new session appeared during the deployment window). Worktree clean; no stash needed. No Discord test posts or bulk rewriting of existing messages.

GitHub CI run 44585908704: Typecheck & Lint passed, including server boot smoke. Broad unit/integration job is still running at this update; local focused validation and production verification are complete. Previously known broad-suite failures remain tracked separately in #287; no claim that the entire remote suite has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant