Skip to content

fix(discord): preserve transcript identity during typing and resize - #291

Merged
johoja12 merged 2 commits into
localfrom
fix/290-discord-history-scope
Nov 19, 2026
Merged

johoja12 merged 2 commits into
localfrom
fix/290-discord-history-scope

Conversation

@johoja12

Copy link
Copy Markdown
Owner

Read-only remote transcript verification includes the native settings/input revision in its identity scope. That revision changes when a person types or a browser resizes the terminal, so a valid transcript read racing those operations is rejected as profile_changed. It also discards a verified runtime-home cache after ordinary input, adding needless SSH probes.

Bind read-only transcript scope to inspectionGeneration, which tracks pane lifecycle and ownership, alongside the existing exact transport, profile, environment/home, conversation pin and before/after native-process verification. Interactive status/settings recovery leases keep their stricter input/geometry revision checks.

Fixes #290.

Reproduced before the fix: two valid Codex reads fail during keyboard/resize revision changes, and the runtime-home cache performs an extra probe. After the fix, 181 tests pass across Codex/Claude remote identity, canonical recovery, connection health and Full-mode integration. Actual pane/owner, runtime fingerprint, profile/home and conversation changes remain refused. Typecheck, changed-source ESLint, changed-file formatting, lockfile and whitespace checks pass.

Live HDAI investigation: local and Mac worker panes alive; effective Codex profile and exact pinned transcript are independently readable, while Discord shows Conversation unverified and activity/UI polling is progressing. This patch fixes a proven verifier race consistent with that discrepancy. The service does not expose per-session raw read failure evidence, so the exact triggering event for this occurrence is inferred; deployment and live follow-up are still needed. No session or agent was restarted, no input was injected, and no production deployment was performed.

Existing broad-CI baseline failures are tracked in #287.

@johoja12
johoja12 merged commit d848c16 into local Nov 19, 2026
@johoja12

Copy link
Copy Markdown
Owner Author

Merged PR #291 and deployed to production local at d848c16f6d85b1cdc91d5a93b57e80c1d7670584, from e08d3810ec84b8d79fc0fe9acd3398197a00fc43. Branch was updated with current production before revalidation (head 7842f435); feature commit 16dbbe2e. Version remains 1.51.0.

Current validation: 129 focused tests passed across remote Codex/Claude identity, history parsing, canonical recovery, connection health, local profiles, catch-up and warnings. Full typecheck, lint, format check, lockfile and whitespace checks passed. Production build succeeded, codeman-web restarted and /api/sessions health passed. Worktree clean; no stash or dependency installation needed.

Fresh runtime checks: all 18 existing session IDs, native conversation pins and original pane PIDs preserved; all panes alive. The deployed dist/discord-history.js reader successfully read w2-hdai's exact remote native conversation 01a1f56b-0399-7f72-9972-a4a2c4aca56b (4 turns), with a changing input-revision getter on a read-only metadata adapter. Discord gateway connected; the actual session settings message contains the correct native conversation and no unverified warning. No prompts were sent or replayed for validation.

Scope: fixes the reproduced typing/resize race in read-only transcript verification; interactive recovery/input leases retain their stricter checks. w2 had already automatically discovered its fresh conversation before deployment. Its exact initial failure trigger was not proven, so this is not a claim that every fresh-session discovery delay is eliminated.

GitHub CI run 44610865027 is still running at this update. Local gates and deployed checks passed; full remote CI is not claimed complete. Prior unrelated broad-suite failures remain tracked separately in #287.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant