Repository navigation
fix: block after Max failed attempts, not Max+1 - #175
Open
lamtrinhdev wants to merge 1 commit into
Open
lamtrinhdev wants to merge 1 commit into
lamtrinhdev wants to merge 1 commit into
Conversation
Contributor
Author
|
Dear @jurajhilje , I have a small fix, when you have time, please help me to review it. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
Problem
IDLimiter.IsAllowed()usedfailedAttemptsInt > l.Max, so the limiter onlykicked in on attempt Max+1 — one more failed attempt than
ID_LIMITER_MAXpromises. The counter is incremented before the check (Tick on failure,
then IsAllowed), so with Max=5 the 6th failed attempt was still "allowed"
and only the 7th got blocked.
Both users of the limiter are affected: TOTP verification (user.go) and
recipient OTP activation (recipient.go).
Fix
One-character change:
>→>=. After the Max-th failure the limiter nowreports blocked, and every further attempt — including one with a valid
code — is rejected until the key expires (
ID_LIMITER_EXPIRATION).