Skip to content

Allow async cell to process Comm messages - #1565

Merged
davidbrochart merged 3 commits into
ipython:mainfrom
davidbrochart:async-cell-waiting-for-comm-reply
Sep 24, 2026
Merged

davidbrochart merged 3 commits into
ipython:mainfrom
davidbrochart:async-cell-waiting-for-comm-reply

Conversation

@davidbrochart

@davidbrochart davidbrochart commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #646 #311

This PR fixes the issue of the kernel deadlocking while running a cell that's waiting for a widget event, bringing it up to par with xeus-python.

  • Add tests
  • Implement the feature

@davidbrochart
davidbrochart force-pushed the async-cell-waiting-for-comm-reply branch from 0277213 to b25b1e1 Compare September 21, 2026 15:12
@davidbrochart

Copy link
Copy Markdown
Collaborator Author

I'll merge and make a release if there is no feedback by tomorrow.

@davidbrochart
davidbrochart merged commit 0273cec into ipython:main Sep 24, 2026
40 checks passed
@davidbrochart
davidbrochart deleted the async-cell-waiting-for-comm-reply branch September 24, 2026 07:35
@kylebarron

Copy link
Copy Markdown

This is exciting! the linked issues have been open for a very long time!

(fyi #311 was not closed automatically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async widget methods deadlock due to on_msg not being called

3 participants