Repository navigation
[PB-7114]: feat/list custom item key via getItemId - #120
Merged
Merged
Conversation
CandelR
reviewed
Nov 16, 2026
| */ | ||
|
|
||
| const List = <T extends { id: number }, F extends keyof T>({ | ||
| const List = <T extends { id?: number | string }, F extends keyof T>({ |
Collaborator
There was a problem hiding this comment.
If T declares id as optional and no getItemId is passed, this compiles, but items without an id break selection. The default getKey returns undefined for all of them, and since undefined === undefined, every row reads as selected and every context menu opens at once. The as string | number cast hides it from the compiler. Reproduced locally. Could getItemId be required when T has no guaranteed id?
CandelR
approved these changes
Nov 16, 2026
Member
Author
|
@CandelR pushed a few changes after your approval so this works better for files without A type with no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
getItemIdprop toListso consumers can choose which field identifies an item. It defaults toitem.id, so existing lists keep working. The generic type no longer requiresid.Added tests for items with duplicated or missing
id. Bumped to 0.1.30.Why
drive-web is moving file identity from
idtouuid, andListcompared items byidinternally.