Skip to content

refactor: remove files.id from drive types - #458

Merged
apsantiso merged 3 commits into
masterfrom
refactor/remove-file-id
Nov 19, 2026
Merged

apsantiso merged 3 commits into
masterfrom
refactor/remove-file-id

Conversation

@apsantiso

@apsantiso apsantiso commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Server is dropping files.id; remove it from SDK types.

  • Drop file id from DriveFileData, SharedFiles (plus typo fileiId) and trash file items.
  • Drop file_id from Thumbnail / ThumbnailEntry (server sends fileUuid; legacy fileId is always 0).
  • DeleteItemsPermanentlyPayload: drop file-by-id variant (server only accepts files by uuid).
  • SearchResult.item.id now optional (only folders have it).
  • Trash methods (getTrashedFilesPaginated, getTrashedItemsSorted, getPersonalTrash) return TrashedFile or TrashedFolder (FolderDto) based on type. FetchTrashContentResponse defaults to TrashedFile.
  • Remove methods whose endpoints are gone:
    • Storage.deleteFile, Trash.deleteFile + DeleteFilePayload
    • Storage.createThumbnailEntry + ThumbnailEntry (use createThumbnailEntryWithUUID)

Breaking

  • Removed fields, methods and types above.
  • Trash methods called with a 'files' | 'folders' variable return TrashedFile | TrashedFolder; narrow before use.

Out of scope

  • src/schema.ts keeps id in FileDto until schema regen (backend hasn't removed it yet!)

- drop numeric file id from DriveFileData, SharedFiles, trash file items and thumbnails
- type trash responses per item type (TrashedFile / TrashedFolder)
- remove deleteFile (storage, trash) and createThumbnailEntry: endpoints no longer exist
@apsantiso apsantiso changed the title refactor!: remove files.id from drive types refactor: remove files.id from drive types Nov 18, 2026
@apsantiso apsantiso self-assigned this Nov 19, 2026
@apsantiso
apsantiso requested a review from CandelR November 19, 2026 10:16
@apsantiso
apsantiso marked this pull request as ready for review November 19, 2026 10:16
@apsantiso
apsantiso merged commit 7af5342 into master Nov 19, 2026
1 check passed
@apsantiso
apsantiso deleted the refactor/remove-file-id branch November 19, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants